Skip to content

Pass kwargs to get_placement_options #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Pass kwargs to get_placement_options #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion autoparallel/optimize_sharding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,11 @@ def build_sharding_metadata(self):
user_args = tree_map_only(
torch.fx.Node, lambda x: x.meta["val"], node.args
)
user_kwargs = tree_map_only(
torch.fx.Node, lambda x: x.meta["val"], node.kwargs
)
strat = get_placement_options(
self.mesh, node.target, user_strats, user_args
self.mesh, node.target, user_strats, user_args, user_kwargs
)
strats[node] = strat
elif node.op == "output":
Expand Down
8 changes: 4 additions & 4 deletions autoparallel/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
from .propagation_rules import _op_partial_rules, _op_rules, remove_invalid_configs


def propagate_tensor_meta(op, user_args, out_strat):
out_t = op(*user_args)
def propagate_tensor_meta(op, user_args, user_kwargs, out_strat):
out_t = op(*user_args, **user_kwargs)

if isinstance(out_t, torch.Tensor):
new_tensor_meta = TensorMeta(out_t.shape, out_t.stride(), out_t.dtype)
Expand Down Expand Up @@ -85,7 +85,7 @@ def fill_missing_redistribute_cost(op, specs, out_strat):
strat.redistribute_cost = redistribute_costs


def get_placement_options(mesh, op, specs, user_args):
def get_placement_options(mesh, op, specs, user_args, user_kwargs):
# print(op)

if op in _op_rules:
Expand Down Expand Up @@ -118,7 +118,7 @@ def get_placement_options(mesh, op, specs, user_args):
op_schema
)

propagate_tensor_meta(op, user_args, out_strat)
propagate_tensor_meta(op, user_args, user_kwargs, out_strat)
fill_missing_redistribute_cost(op, specs, out_strat)
out_strat = remove_invalid_configs(out_strat, mesh)

Expand Down