Enable local builds with FFmpeg8 #935
Open
+74
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 8 as an option in
load_torchcodec_shared_libraries()
and_core/CMakeLists.txt
to enable FFmpeg8 builds.In addition, to enable local builds with FFmpeg8, we need to update our pixel_format setting approach.
Old flow (<= FFmpeg7) :
avfilter_graph_create_filter()
av_opt_set_int_list
.New flow (>= FFmpeg8) :
avfilter_graph_alloc_filter
av_opt_set
avfilter_init_str
.These changes are encapsulated
FFmpegCommon.h
increateBuffersinkFilter()
, which either returnsAVFilterContext*
ornullptr
if an error occurred.