Merged
Conversation
Jack-Khuu
reviewed
Oct 2, 2025
felipemello1
reviewed
Oct 3, 2025
felipemello1
reviewed
Oct 3, 2025
felipemello1
reviewed
Oct 3, 2025
Contributor
Author
|
Quick updates:
|
Jack-Khuu
approved these changes
Oct 6, 2025
Contributor
Jack-Khuu
left a comment
There was a problem hiding this comment.
Legit
Non-code ask:
- Install instructions (README or just put in the PR description, until it's ready for the core install file)
Contributor
Author
good call, added to the PR description |
joecummings
reviewed
Oct 6, 2025
|
|
||
| async def stop_proc_mesh(self, proc_mesh: ProcMesh): | ||
| """Stops a proc mesh.""" | ||
| if proc_mesh not in self._proc_host_map: |
Contributor
Author
There was a problem hiding this comment.
for some reason a bunch of unit tests were failing due to wrong cleanup. Not sure why I saw this in this PR specifically, but we should have this line anyways. If we want to be really clean I can add this in a separate PR
joecummings
approved these changes
Oct 6, 2025
Member
joecummings
left a comment
There was a problem hiding this comment.
Couple nits, but looks good!
photomz
pushed a commit
to photomz/forge
that referenced
this pull request
Oct 25, 2025
* hello coder * docstrings * undo vllm example * add coder test * double stop doesn't work * address comments * reset -> recreate * remove line * final cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up for #188
Enroot install instructions are here. Commands: