Explicitly add imports for java classes#29
Conversation
slipset
force-pushed
the
add_imports
branch
from
dce6259 to
30b43e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 67.82% 67.77% -0.06%
==========================================
Files 9 9
Lines 575 574 -1
Branches 70 70
==========================================
- Hits 390 389 -1
Misses 115 115
Partials 70 70
Continue to review full report at Codecov.
|
slipset
force-pushed
the
add_imports
branch
3 times, most recently
from
d83c575 to
8eb0610
Compare
- Type hints were in the wrong place - Protocol type hints seem to have to be fully qualified (at least when used with potemkin - Remove typehints where not needed
slipset
force-pushed
the
add_imports
branch
from
8eb0610 to
2834568
Compare
| (->X509Certificate ^java.security.cert.X509Certificate [this] | ||
| (^java.security.cert.X509Certificate ->X509Certificate [this] |
There was a problem hiding this comment.
I'm pretty sure the :tag is supposed to go on the argslist and not the method name
| ^java.security.PrivateKey [this] | ||
| ^java.security.PrivateKey [this ^String algorithm] | ||
| [this] | ||
| [this ^String algorithm] |
There was a problem hiding this comment.
what's the reason for removing these tags?
|
I'm of two minds about a change like this. I do like making the code a little less cluttery by importing all of the class names. It makes working on the library code a little nicer. On the other hand, I think having the full class names present everywhere makes the library easier to use for consumers of the library. If you're using the library and you jump to a function definition it saves you a step to know it takes a |
2 participants
No description provided.