This repository was archived by the owner on Nov 30, 2022. It is now read-only.
fixed two bugs when switching accounts from the ComposeView #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes issue #72
relevant quotes from there that pretty much sum it up:
and
i fixed the first part by:
CompositionViewModel.maxCharactersinto a Publisher$maxCharactersis updatedmaxCharactersvia a helper method wheneverNewStatusViewModel.$identityContextis updatedand i fixed the second part, in
CompositionView, by moving the call toparentViewModel.identityContext.$authenticatedOtherIdentities.sink()into the trailing end of the callback given toparentViewModel.$identityContext.sink().the problem there, originally arose because whenever the user switches accounts, the
identityContextgets completely replaced by a new object. so when, later on, eventually, the newidentityContext.authenticatedOtherIdentitiesgot updated, nothing was subscribed to it. and so callingidentityContext.$authenticatedOtherIdentites.sink()on every change toidentityContexthas fixed itOther Information