Skip to content

Conversation

trgwii
Copy link
Member

@trgwii trgwii commented Sep 19, 2025

Description

  • Get rid of some buffer overruns
  • make more functions return more sensible things on NULL arguments
  • properly DOCUMENT each function
  • Add const type qualifiers where applicable
  • Replace some string functions and loops with memcpy

This fixed some broken tests when I cloned with a "." in my parent path (like /github.com/metacall/core/...)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (code comments).
  • My changes generate no new warnings.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
  • I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
  • I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
  • I have tested with Helgrind in case my code works with threading.
  • I have run make clang-format in order to format my code and my code follows the style guidelines.

If you are unclear about any of the above checks, have a look at our documentation here.

…path_get_name, portability_path_get_name_canonical

- Get rid of some buffer overruns
- make more functions return more sensible things on NULL arguments
- properly DOCUMENT each function
- Add const type qualifiers where applicable
- Replace some string functions and loops with memcpy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant