Fix online resource validation messages #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current online resources validation it can be unclear to the user that there are empty alternate language values. If a user manually inputs
PDFin the format field without clicking the typeahead suggestion, the French value will not be updated:This produces the following validation message:
This message is confusing as it does not specify it is the French value that is missing. Additionally there is a space missing after the colon in this message.
This PR aims to fix these issues by adding new validation messages specific to missing or invalid values for each language and by implementing these messages in the schematron. Additionally the messages that were missing spaces after colons have been updated with the missing spaces.