Check for Open Government license specifically #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
So the challenge is then that GC_Open_Licenses.rdf ... contains licences that are not Open Government Licenses. Okay I think I can see how that makes sense. |
jodygarnett
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we want to add additional licenses we need to update the
GC_Open_Licenses.rdf. This however introduces an issue as that new license would also cause the record to pass validation.This PR aims to solve this issue by checking for Open Government licenses specifically instead of checking for any license in the
GC_Open_Licenses.rdf.With these changes we can now add additional optional licenses to
GC_Open_Licenses.rdfto be displayed as suggestions while still requiring at least one Open Government license.Additionally the required licenses are set using a
required-licensesvariable at the top of the schematron to facilitate customization.