Change set_* functions to not create intermediate structures.
#704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackwinter
commented
Jul 24, 2025
|
We should add playground examples as well as provide a reference to the add_functions in the docu since it could help newcomers. |
TobiasNx
added a commit
to metafacture/metafacture-playground
that referenced
this pull request
Jul 31, 2025
fsteeg
reviewed
Jul 31, 2025
...tafix/integration/record/fromJson/toJson/set_arrayIntoArrayOfObjectsWithAppend/expected.json
Outdated
Show resolved
Hide resolved
fsteeg
reviewed
Aug 1, 2025
…el. (#704) The current "element" designated by `$append`/`$prepend` is not considered "intermediate structure".
fsteeg
approved these changes
Aug 1, 2025
|
Thank you both for the thorough reviews! Good catches :) The playground example for |
blackwinter
deleted the
631-changeSetFunctionsToNotCreateIntermediateStructures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #631.
Mirroring Catmandu's behaviour: "will not create the intermediate structures if they are missing".
The playground example for
set_fielddoesn't exist yet. Is it going to be added or should I remove the link from the README?