Merged
Conversation
2 tasks
|
@pgoslatara note that you'll need to publish a new release of your package for the new dependency to be considered during dbt deps! |
|
Doh @tpoll not Pádraic! my bad |
Contributor
|
https://github.com/metaplane/dbt-expectations/releases/tag/0.10.8 release should pick this up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Addresses #6. Xebia (formerly called GoDataDriven) have forked Calogica's
dbt-datepackage (here) and will maintain it going forward as they are a partner of dbt Labs.Why Do We Need These Changes
If there is ever a feature or bug in
dbt-expectationsthat relates todbt-datethen it would force Metaplane to fork and support their owndbt-datepackage. With Xebia's support this burden is now shared across the community.Reviewers
@tpoll @gusvargas