Skip to content

Fix #23 stop assigning list from list.append#24

Merged
GuruM merged 1 commit intometaplane:mainfrom
VDFaller:main
Dec 1, 2025
Merged

Fix #23 stop assigning list from list.append#24
GuruM merged 1 commit intometaplane:mainfrom
VDFaller:main

Conversation

@VDFaller
Copy link
Contributor

@VDFaller VDFaller commented Jul 29, 2025

Summary of Changes

Fixes #23
Change {% set columns = columns.append(...) %} to {% do columns.append(...) %}

Why Do We Need These Changes

Otherwise dbt-fusion won't work with dbt-expectations. They said they don't plan on fixing dbt-labs/dbt-fusion#484, which seems reasonable.

Reviewers

@tpoll @gusvargas

@owenprough-sift
Copy link

@GuruM (since you've reviewed/merged PRs in this repo recently): what is the process for getting review on community-submitted PRs?

@VDFaller
Copy link
Contributor Author

VDFaller commented Dec 1, 2025

Awesome! Thanks @GuruM, now we can go back to the maintained version.

@GuruM GuruM merged commit f93478c into metaplane:main Dec 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] list.append functionality changing in dbt fusion

3 participants