fix: expect_column_values_to_have_consistent_casing correctly dealing with NULL values#28
Open
jvanbuel wants to merge 1 commit intometaplane:mainfrom
Open
fix: expect_column_values_to_have_consistent_casing correctly dealing with NULL values#28jvanbuel wants to merge 1 commit intometaplane:mainfrom
jvanbuel wants to merge 1 commit intometaplane:mainfrom
Conversation
… with NULL values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR fixes #27 where NULL values in a column cause the
expect_column_values_to_have_consistent_casingto fail for an otherwise consistently cased column.I've added the change, and updated the tests so that they fail without the fix, and succeed with the fix.
Why Do We Need These Changes
The current implementation fails for columns with consistent casing that contain NULL values. When enabling the
display_inconsistent_columnsfeature of the test, the test succeeds because of the changes in the underlying logic.Reviewers
@tpoll @gusvargas