fix: change group by alias to positional to support trino engine#40
Open
kovipaulo wants to merge 1 commit intometaplane:mainfrom
Open
fix: change group by alias to positional to support trino engine#40kovipaulo wants to merge 1 commit intometaplane:mainfrom
kovipaulo wants to merge 1 commit intometaplane:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changed the grouping logic in the expect_row_values_to_have_data_for_every_n_datepart test macro. Specifically, replaced the alias-based grouping (group by date_{{date_part}}) with a positional grouping (group by 1).
Why Do We Need These Changes
This change fixes a SQL compilation error when running this test on Trino or Presto engines.
These engines resolve the GROUP BY clause before the SELECT projection, meaning they cannot resolve the column alias defined in the SELECT statement, causing a "Column not found" error.
Using GROUP BY 1:
Closes #39
Reviewers
@GuruM