WIP: Drop old collector.prototyp implementation#434
Open
tshemsedinov wants to merge 2 commits intomasterfrom
Open
WIP: Drop old collector.prototyp implementation#434tshemsedinov wants to merge 2 commits intomasterfrom
tshemsedinov wants to merge 2 commits intomasterfrom
Conversation
It's because old implementation does not satisfy latest tests and we have modern implementation on prototypes. Old one is quick but this speed is a result of less functionality, not the different approach.
tshemsedinov
force-pushed
the
refactor-collection
branch
from
f79188e to
e64387f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.