Call original debounced function with proper "this" context#456
Open
Call original debounced function with proper "this" context#456
Conversation
- reuse timer if the refresh method is available - call original function with "this" of debounced function
Member
Author
|
The CI is failing as Node.js 12 does not support the optional chaining operator. Should I update my code, or could we just drop Node.js 12 as it has got its end of life at 2022-04-30? |
georgolden
approved these changes
Dec 3, 2022
tshemsedinov
requested changes
Dec 3, 2022
Member
tshemsedinov
left a comment
tshemsedinov
left a comment
There was a problem hiding this comment.
We can't drop node12 support as of now because metasync is quite old library and we use it in multiple legacy projects, so please rewrite without optional chaining operator.
- fix backward compatibility with Node.js 12 - add ability to call debounced function with new arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes
metasyncpreserves debounced function's "this" contextmetasyncAPIChecks
npm t)npm run fmt)