Merged
Conversation
HaoZeke
force-pushed
the
fixClone
branch
2 times, most recently
from
f20056d to
80add6f
Compare
HaoZeke
force-pushed
the
fixClone
branch
4 times, most recently
from
5792564 to
e73f7c1
Compare
HaoZeke
changed the title
Member
Author
|
cc @Luthaf should be good to go, then a release and we're set on the |
4 tasks
Luthaf
reviewed
Feb 6, 2026
Member
Luthaf
left a comment
Luthaf
left a comment
There was a problem hiding this comment.
Looks good, I have two small questions
Into::<ArcArray<A, D>>::into will not clone unlike into_shared()
Luthaf
approved these changes
Feb 6, 2026
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically for cases where we don't want to actually take ownership of the data pointer. Basically extracted from metatensor/metatensor#1025.