feat(datatypes): handle complex numbers#22
Merged
Luthaf merged 3 commits intometatensor:mainfrom Feb 9, 2026
Merged
Conversation
HaoZeke
force-pushed
the
handleComplex
branch
from
bbe995d to
a651010
Compare
19 tasks
Luthaf
previously approved these changes
Feb 9, 2026
Luthaf
reviewed
Feb 9, 2026
Luthaf
reviewed
Feb 9, 2026
HaoZeke
force-pushed
the
handleComplex
branch
from
efb8e29 to
785e5c6
Compare
Luthaf
reviewed
Feb 9, 2026
Comment on lines
27
to
+29
| ndarray = ["dep:ndarray"] | ||
| pyo3 = ["dep:pyo3"] | ||
| half = ["dep:half"] |
Member
There was a problem hiding this comment.
I'm wondering if this is what prevent automatic feature activation from metatensor. Let me try locally (and I'll send a separate PR in this case)
Member
There was a problem hiding this comment.
ok, apparently this is not required (https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies) but we have to enable them when using them anyway. Am I remembering how stuff worked previously?
Member
Author
There was a problem hiding this comment.
TBH I haven't done enough package management in Rust to recall :D
Luthaf
approved these changes
Feb 9, 2026
Member
|
(do not merge, I'll rebase locally to get 3 commits) |
Luthaf
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also as discussed today... this also involves an API change, making
DLPackPointerCastpublic.and some optional
halfstuff.