Closed
Conversation
10 tasks
|
Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from PR #237, and completes a TODO item in #239 , the next public API function implemented is the
correlate_tensorsmethod. This takes two arbitrary TensorMaps and performs a single Clebsch-Gordan tensor product. The functioncorrelate_densitypreviously implemented in #237, is a special case of this method, used to correlate a density descriptor with itself.As this is the general case, the method cannot take computational shortcuts as in
correlate_density. As such, the public API function signature is simplified to:where arg
selected_keyscontrols the output of angular and parity channels, and therefore the block combinations performed.Other Changes
correlate_density: TensorMaps are now returned with the "order_nu" and "inversion_sigma" key dimensions, even if they are not sparse (i.e. redundant). This metadata should be carried around to allow passing of TensorMaps to CG functions that require it (i.e.correlate_tensors), and can always be easily removed by the user if they wish. Once TensorMaps can be tagged with global (i.e. non-sparse) metadata, they will be moved there (another breaking change, for the future)