Fix cartesian_to_spherical for rank > 2 tensors and real_to_complex transformation#371
Merged
Fix cartesian_to_spherical for rank > 2 tensors and real_to_complex transformation#371
cartesian_to_spherical for rank > 2 tensors and real_to_complex transformation#371Conversation
Contributor
Author
|
We'll have to make some changes for properly dispatching operations |
Member
|
Thanks for doing this! Do you have a test, some function that proves that the new behavior is correct? Ideally something like in #353 |
Contributor
Author
|
Just locally in a notebook, we will add some tests soon |
jwa7
changed the title
cartesian_to_spherical for rank > 2 tensors and real_to_complex transformation
Luthaf
reviewed
Jan 27, 2025
…(page 254 Sakurai) is enforced
Member
|
Think we're ready for re-review @Luthaf ! @MichelangeloDomina checked |
Luthaf
reviewed
Jan 31, 2025
Co-authored-by: Guillaume Fraux <guillaume.fraux@epfl.ch>
Co-authored-by: Guillaume Fraux <guillaume.fraux@epfl.ch>
Luthaf
approved these changes
Jan 31, 2025
Member
|
Thank! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #370
To Do:
cartesian_to_sphericalon higher-rank tensors📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request