Explain key matching in docstring of DensityCorrelations#373
Merged
Conversation
Member
Author
|
@Luthaf I for some reason can't assign Matthias (@bananenpampe ) as a reviewer - does he need to be added as a contributor? |
Member
|
Yes, he would need to be added at leat to the organization. I can do that if he wants to! Otherwise, one does not need to be assigned as a reviewer to actually review, anyone can review any PR anywhere! |
Luthaf
reviewed
Jan 27, 2025
python/featomic/featomic/clebsch_gordan/_density_correlations.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_density_correlations.py
Outdated
Show resolved
Hide resolved
Member
|
CI should be fixed by #374 |
Co-authored-by: Guillaume Fraux <guillaume.fraux@epfl.ch>
Co-authored-by: Guillaume Fraux <guillaume.fraux@epfl.ch>
Member
|
CI failure looks related, could you update the branch & re-format? |
Luthaf
reviewed
Jan 31, 2025
Member
Luthaf
left a comment
Luthaf
left a comment
There was a problem hiding this comment.
Looks good to me. @bananenpampe is the new docstring clearer?
Luthaf
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #372
📚 Download documentation for this pull-request