Adds sample selection to equivariant power spectrum#376
Merged
Luthaf merged 5 commits intometatensor:mainfrom Jan 30, 2025
Merged
Adds sample selection to equivariant power spectrum#376Luthaf merged 5 commits intometatensor:mainfrom
Luthaf merged 5 commits intometatensor:mainfrom
Conversation
Luthaf
reviewed
Jan 29, 2025
| import numpy as np | ||
| import pytest | ||
| from metatensor import Labels, TensorBlock, TensorMap | ||
| from metatensor.operations import equal, join |
Member
There was a problem hiding this comment.
Please don't import from metatensor.operations. This could be written
from metatensor import equal, join
Or even better
Suggested change
| from metatensor.operations import equal, join | |
| import metatensor as mts |
and down the line mts.equal, mts.join
(like you would not do from numpy import log but instead use np.log where required)
Member
|
Thanks, looks very good overall! I just have one style comment about importing metatensor operations. |
jwa7
reviewed
Jan 29, 2025
python/featomic/tests/clebsch_gordan/equivariant_power_spectrum.py
Outdated
Show resolved
Hide resolved
…m.py Co-authored-by: Joseph W. Abbott <joseph.william.abbott@gmail.com>
Contributor
Author
|
test makes the naming consitent with the other tests |
Luthaf
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds sample selection to the equivariant power spectrum convenience class.