Skip to content

Make sure Labels are created with the correct device#403

Merged
Luthaf merged 1 commit intometatensor:mainfrom
Luthaf:fix-device
Sep 17, 2025
Merged

Make sure Labels are created with the correct device#403
Luthaf merged 1 commit intometatensor:mainfrom
Luthaf:fix-device

Conversation

@Luthaf
Copy link
Member

@Luthaf Luthaf commented Sep 16, 2025

Fix #399

@LorenzoPiersante, do you have some time to check this works for you?

@Luthaf Luthaf requested a review from jwa7 September 16, 2025 14:40
@Luthaf Luthaf mentioned this pull request Sep 16, 2025
@LorenzoPiersante
Copy link

@Luthaf thanks a lot! Just to ensure I know what is going on, is it sufficient to pip reinstall featomic?

@jwa7
Copy link
Member

jwa7 commented Sep 17, 2025

Hi @LorenzoPiersante - yes you should be able to just pip install from source, by cloning the repository :)

Copy link
Member

@jwa7 jwa7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Luthaf !

@Luthaf
Copy link
Member Author

Luthaf commented Sep 17, 2025

To expand on @jwa7 answer: you'll be able to pip install git+https://https://github.com/metatensor/featomic/ once this is merged, but this requires you to build the code from sources and have all compilers installed.

You'll be able to pip install featomic and get a pre-compiled version of the code once #402 and a similar PR for featomic-torch are merged.

@Luthaf Luthaf merged commit 6805203 into metatensor:main Sep 17, 2025
21 checks passed
@Luthaf Luthaf deleted the fix-device branch September 17, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device for density correlations

3 participants