Skip to content

This fixes the constant rebuilds even if nothing changed#418

Merged
Luthaf merged 3 commits intometatensor:mainfrom
MilitaoLucas:fix_rebuilds
Jan 5, 2026
Merged

This fixes the constant rebuilds even if nothing changed#418
Luthaf merged 3 commits intometatensor:mainfrom
MilitaoLucas:fix_rebuilds

Conversation

@MilitaoLucas
Copy link
Contributor

When featomic is used as a library, with Externalproject_add or CPM.cmake, every time the project that depends on metatensor/featomic is built, this forces the project to re-link because it updates the timestamp of the lib. This PR aims to fix this

Contributor (creator of pull-request) checklist

  • Tests updated (for new features and bugfixes)?
    Not applicable
  • Documentation updated (for new features)?
    Not applicable
  • Issue referenced (for PRs that solve an issue)?
    Couldn't find any relevant issue

Reviewer checklist

  • CHANGELOG updated with public API or any other important changes?

Copilot AI review requested due to automatic review settings January 5, 2026 15:04

This comment was marked as spam.

@metatensor metatensor deleted a comment from Copilot AI Jan 5, 2026
@metatensor metatensor deleted a comment from Copilot AI Jan 5, 2026
@metatensor metatensor deleted a comment from Copilot AI Jan 5, 2026
@metatensor metatensor deleted a comment from Copilot AI Jan 5, 2026
@Luthaf Luthaf merged commit 02f4ad0 into metatensor:main Jan 5, 2026
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants