Use Cholesky decomposition for a more stable LLPR#1043
Open
frostedoyster wants to merge 3 commits intomainfrom
Open
Use Cholesky decomposition for a more stable LLPR#1043frostedoyster wants to merge 3 commits intomainfrom
frostedoyster wants to merge 3 commits intomainfrom
Conversation
ppegolo
reviewed
Feb 12, 2026
| # normal distribution | ||
| ensemble_displacements = ( | ||
| torch.linalg.solve_triangular( | ||
| cur_cholesky.T, |
Contributor
There was a problem hiding this comment.
Can't we avoid transposing and passing upper=False?
Collaborator
Author
There was a problem hiding this comment.
It's not the same as far as I understand
Collaborator
Author
|
cscs-ci run |
3 similar comments
Collaborator
Author
|
cscs-ci run |
Contributor
|
cscs-ci run |
Collaborator
Author
|
cscs-ci run |
Collaborator
Author
|
cscs-ci run |
2 similar comments
Collaborator
Author
|
cscs-ci run |
Collaborator
Author
|
cscs-ci run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor (creator of pull-request) checklist
Documentation updated (for new features)?Issue referenced (for PRs that solve an issue)?Maintainer/Reviewer checklist
📚 Documentation preview 📚: https://metatrain--1043.org.readthedocs.build/en/1043/