Conversation
…a-chorna/metatrain into architecture-coverage-test
…a-chorna/metatrain into architecture-coverage-test
| with: | ||
| python-version: "3.13" | ||
| - run: pip install tox | ||
| - run: pip install tox coverage[toml] |
There was a problem hiding this comment.
Is it possible to do this in tox.ini instead of here in the workflow file?
There was a problem hiding this comment.
Then it would generate the coverage also when running locally
There was a problem hiding this comment.
Hmm worth trying then, thanks for suggestion
The llpr/gap/nanopet parts of the code should also have tests, it is weird there is 0 coverage reported for these. |
…osmo/metatrain into architecture-coverage-test
|
|
||
| .. image:: https://codecov.io/gh/metatensor/metatrain/branch/main/graph/badge.svg?flag=coverage_nanopet | ||
| :target: https://codecov.io/gh/metatensor/metatrain/tree/main/src/metatrain/deprecated/nanopet | ||
|
|
There was a problem hiding this comment.
It's very nice to show this here. Right now they show as codecov: unknown, they will work once the PR is merged to main?
It would be better to add the badge automatically instead of manually in each documentation.py file. The string could be added here:
metatrain/docs/src/architectures/generate.py
Lines 220 to 222 in 91ee3e3
after f".. _architecture-{template_variables['architecture']}:" + "\n\n". You can try to do it and let me know if you have doubts :)
There was a problem hiding this comment.
it is unknown as it is not in main. here is the example of badge pointing to this branch:
https://codecov.io/gh/metatensor/metatrain/branch/architecture-coverage-test/graph/badge.svg?flag=coverage_nanopet
I wouldn't do it atomatically as it should be also set up in .codecov.yml
Let me know if you see better approach please
There was a problem hiding this comment.
Hmm I see, but if we do it automatically and it is not set in .codecov.yml it will just show "Unknown" no? Seems fine.
Also I would then add the instruction to add your architecture in .codecov.yml here: https://github.com/metatensor/metatrain/blob/main/docs/src/dev-docs/new-architecture.rst
There was a problem hiding this comment.
Ah okay, seems fine indeed. Thanks
|
So I'm not 100% sure the way we partition the coverage between architectures is working, it looks like we would have to merge first to know about this. Looking around codecov, this seems very relevant: https://docs.codecov.com/docs/components, should we use it instead of multiple projects? |
Indeed, very good point. Checking the components |
|
Converting to draft to play with it (sorry, forking does not work with codecov) |

Please go the the
Previewtab and select the appropriate PR template:📚 Documentation preview 📚: https://metatrain--803.org.readthedocs.build/en/803/