Perform repo initialization via array of structs#1
Open
antifuchs wants to merge 1 commit intometcalf:masterfrom
Open
Perform repo initialization via array of structs#1antifuchs wants to merge 1 commit intometcalf:masterfrom
antifuchs wants to merge 1 commit intometcalf:masterfrom
Conversation
The method of initializing the repo via a map[string]**sqlx.NamedStmt usually works well, until you hit the case where two identical SQL statements should be registered somewhere (this probably happens more in tests than it does in real life, but it can plausibly happen). Making the initialization loop operate on an array of structures sidesteps this problem quite nicely: With this change, every SQL statement can get registered on a NamedStmt field, no matter what its shape or how similar it is to other statements on the repository.
Author
|
It occurs to me that you could get the exact benefits of this change with the lining-up nature of key/value things in maps by just flipping the map type from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @nelhage and I discussed out-of-band earlier today, using a
map[string]**sqlx.NamedStmtworks well until you have to put two of the same SQL statement into the repository: Suddenly, one slot stops getting initialized. The change in this PR alters the initialization loop to use an array of structs, which eliminates the uniqueness requirement and should give us all some peace of mind (:Slight downside is that there's a little bit more line noise and that what was nicely lined-up key/value pairs before no longer lines up. But I believe the gain in correctness is worth it.