Updated approx implementation to exclude sets and Documentation cleanup for approx#5
Open
fumedev[bot] wants to merge 1 commit intotest5from
Open
Updated approx implementation to exclude sets and Documentation cleanup for approx#5fumedev[bot] wants to merge 1 commit intotest5from
approx implementation to exclude sets and Documentation cleanup for approx#5fumedev[bot] wants to merge 1 commit intotest5from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGED
__repr__method in theApproxSequencelikeclass to specifically check for sequence types (e.g., list, tuple) and exclude sets. Added a TypeError raise if a set is passed toapprox._yield_comparisonsmethod to raise a TypeError if a set is passed toapprox, ensuringpytest.approx()does not support sets as input.doc/en/usage/assertions.rstto update the documentation forapproxand removed any mention that implies support for sets, clarifying thatapproxonly supports sequence types like lists and tuples with ordered elements.