Dependencies updates, only import necessary Lodash functions and upda…

[paulincai]

…te syntax for new library versions.

[zodern]

Thanks @paulincai. Did you check if config validation still works? I might need to update Meteor Up to support validation errors from the latest joi version.

[paulincai]

Hi @zodern no detailed checks. I implemented the new syntax around Joi, built and used to deploy. I can confirm that deploys work. Ok, I will do some tests. Let's keep this open for now.

[paulincai]

@zodern
Ok, I did a console log where validation occurs:
src/index.js

export const validate = {
  app(config, utils) {
    if (config.app?.type === 'aws-beanstalk') {
      console.log({ config, utils }, validator(config, utils));    // HERE

      return validator(config, utils);
    }

    return [];
  }
};

The result:

{
  config: {
    app: {
      type: 'aws-beanstalk',
      name: 'web-users',
      path: '../',
      region: 'eu-central-1',
      forceSSL: true,
      env: [Object],
      auth: [Object],
      customBeanstalkConfig: [Array],
      minInstances: 1,
      maxInstances: 1,
      oldVersions: 3,
      buildOptions: [Object],
      instanceType: 't2.micro'
    },
    plugins: [ '@activitree/mup-aws-beanstalk' ],
    _origionalConfig: { app: [Object], plugins: [Array] }
  },
  utils: {
    improveErrors: [Function: improveErrors],
    addLocation: [Function: addLocation],
    combineErrorDetails: [Function: combineErrorDetails],
    serversExist: [Function: serversExist],
    addDepreciation: [Function: addDepreciation],
    VALIDATE_OPTIONS: { abortEarly: false, convert: false, noDefaults: true }
  }
} []

The last array in the result above is the validation result ( validator(config, utils) ).
Will update the code now as I also did a eslint --fix and there are small changes here and there (for instance default exports for a couple of functions and a function was missing a name)

[paulincai]

Ok, I don't really like brackets for single parameter fat arrow functions ((app) => something) but this is how the linter is set so will go with it. @zodern I thing the pull request contains now the updates. I am here in case you would like me do add or change something.

[zodern]

@paulincai do you know what the new minimum node version supported by the updated dependencies are? The docs still say mup-aws-beanstalk works with Node 4, so we will probably need to update that.

[paulincai]

I could look at those 1 by 1. There is another option I think of.
Make 0.7.0 recommended for Node14+ and 0.6.x for everything else. I think 0.7.0 started mainly to answer to Amazon Linux 2 machines (Node14).
This is development side of tech and if one cannot run 0.7.0 in a Node10 can just install 0.6.x and give it another try.