Aws v3, worker environments, deployment logs#178
Open
fumbleforce wants to merge 8 commits intometeor-up:masterfrom
Open
Aws v3, worker environments, deployment logs#178fumbleforce wants to merge 8 commits intometeor-up:masterfrom
fumbleforce wants to merge 8 commits intometeor-up:masterfrom
Conversation
Author
|
@zodern Thoughts? |
Contributor
|
This looks awesome! Thanks for making the effort. |
Collaborator
|
Thanks @fumbleforce. This does look really nice. Thanks for working on it. I'll try to review it within the next couple of weeks. |
Author
|
Had any time to review? |
added 3 commits
May 2, 2024 10:32
zodern
reviewed
May 3, 2024
| # Install nvm | ||
| curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.6/install.sh | bash | ||
| [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" | ||
| if [[ $MAJOR_NODE_VERSION == "14" && $MINOR_NODE_VERSION -ge 21 ]]; then |
Collaborator
There was a problem hiding this comment.
It might be helpful to look at how we fixed this in the zodern:meteor docker image: https://github.com/zodern/meteor-docker/blob/467ec350e3a4d6ba93987b8d14eaa8cc79959a67/image/scripts/setup_nvm.sh#L21-L38
It copies Meteor's node into nvm's folder so nvm is able to use it. You'll also want to check the patch version, since Meteor's node version uses the same minor version as some official releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the AWS package to the new V3 scheme, which has separate packages to for each AWS service.
Assisting in the rewrite was the addition of Typescript definitions.
The upgrade has worked for my use cases so far.
Additional features:
Worker environments
Environments can be set to be "workers", which do not have a web-facing load balancer.
Deployment log
You can choose to stream the logs from newly created instances into the console during deployments. This is to get more direct feedback during failed deployments, as having to dig through s3 buckets for lost instance logs is a pain.