Support sever-side rendering#92
Conversation
|
I realize now, that there is already a pull request for this, but I offer a solution without code repetition. If you are happy with this solution I will update the tests; all are passing, however I should remove some isClient conditions. |
|
Keep in mind, it's been a over a year since I've worked with Meteor in a routine fashion, and never attempted server-side scripting (SSR), and know nothing of how flow-router-ssr works. I opposed this feature in the past for reasons [1]. [1]: #63 (comment) Some concerns off the top of my head.
If SSR simulates a user-agent in an isolated environment that can be destroyed at the end of the request, then my concerns are moot, but if this was the case, why would we need CountsCollection on the server side? The current client-side code would create a Counts collection in that isolated environment. I reserve the right to introduce other concerns as they come to me. That said, I'm not 100% against this feature, but when I don't understand how a solution avoids introducing bugs in user applications, then I won't support it until I do. Ultimately, I'd like @tmeasday to weigh in as he understands the goals of this project better than I, and this feature was generally considered beyond the scope of this package. |
|
Jack Martin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Allow server side rendering when using React with kadira:flow-router-ssr. This allows all subscriptions to be processed on the server side without throwing an error.