Support use of Google Film for temporal interpolation #2270

gavinevans · 2025-12-18T16:21:11Z

Addresses https://github.com/metoppv/mo-blue-team/issues/763
improver_test_data PR: metoppv/improver_test_data#118

Description
This PR adds two pieces of functionality:

Extends the existing temporal interpolation to support specifying "google_film" as an option.
Adds a ForecastTrajectoryGapFiller plugin and CLI for filling gaps in the forecast trajectory (i.e. validity time or, equivalently forecast period, when considering forecasts from a fixed forecast reference time), or smoothing across transitions between different forecast sources. This is a slightly different set-up to the existing temporal interpolation plugin and CLI, which is expecting a start and end cube only.

File breakdown:

envs/environment_a.yml - Add Tensorflow and Tensorflow_hub to environment to be able to use Google Film.
envs/latest.yml - Add Tensorflow and Tensorflow_hub to environment to be able to use Google Film.
improver/cli/forecast_trajectory_gap_filler.py - A CLI for the ForecastTrajectoryGapFiller plugin. This is a sister CLI to the temporal-interpolate CLI but is intended to take a collection of validity times for a forecast from a fixed forecast reference time and fill gaps, or smooth across transitions between forecast sources.
improver/cli/temporal_interpolate.py - Modifications to add "google_film" as an option.
improver/utilities/temporal_interpolation.py - Modifications to the existing TemporalInterpolation plugin and addition of the ForecastTrajectoryGapFiller and GoogleFilmInterpolation plugin. The GoogleFilmInterpolation plugin is accessed through either the TemporalInterpolation or ForecastTrajectoryGapFiller plugins.
improver_tests/acceptance/SHA256SUMS - Checksum updates.
improver_tests/acceptance/test_forecast_trajectory_gap_filler.py - Acceptance tests for new CLI. This uses linear interpolation. The Google Film interpolation is more time-consuming.
improver_tests/acceptance/test_temporal_interpolate.py - Add an example acceptance test that uses Google Film. This takes a bit longer than most other acceptance tests and relies upon accessing the Google FILM url.
improver_tests/utilities/test_ForecastTrajectoryGapFiller.py - Unit tests for ForecastTrajectoryGapFiller plugin.
improver_tests/utilities/test_GoogleFilmInterpolation.py - Unit tests for GoogleFilmInterpolation plugin.
improver_tests/utilities/test_TemporalInterpolation.py - Unit tests for TemporalInterpolation plugin.

Testing:

Ran tests and they passed OK
Added new tests for the new feature(s)

…pecific plugin and addition of a Google Film option to the temporal interpolation plugin and CLI.

…he situation where a range of forecast periods are available, but within this range there are gaps to be filled. This class also checks an attribute, which contains information about the forecast source at each forecast period. Forecast periods at which there is a transition from one forecast source to another will be the target for the interpolation.

bayliffe

A nice round 30 comments for you.

envs/environment_a.yml

improver/cli/forecast_period_gap_filler.py

improver/cli/temporal_interpolate.py

improver_tests/utilities/test_GoogleFilmInterpolation.py

* upstream/master: BUG: gh actions coverage report (metoppv#2269) Bump actions/checkout from 5 to 6 (metoppv#2272) Bump actions/github-script from 7 to 8 (metoppv#2271) Fix acceptance tests that were relying on a warning being raised (metoppv#2268) Merge CLI and application UI improvements (metoppv#2222) OrographicEnhancement CLI -> MetaOrographicEnhancement application (metoppv#2221)

… batched approach used for Google Film interpolation.

…parallel backend available using the joblib package.

bayliffe

I believe you will need to modify the improver_production environment in the long term, but for now the improver_tests/acceptance/test_temporal_interpolate.py test fails when running the acceptance tests as the tensorflow_hub module is not found. You need to extend your pytest.skip test to include not only the availability of the google film model but also the tensorflow_hub module.

improver/utilities/temporal_interpolation.py

improver_tests/acceptance/acceptance.py

bayliffe

Thanks Gavin. Automated tests failing, but ready for second review.

maxwhitemet

Thanks @gavinevans. I've added some comments.

improver/utilities/temporal_interpolation.py

improver/cli/forecast_trajectory_gap_filler.py

gavinevans · 2026-01-28T17:58:07Z

Note that some functions in this PR are deliberately not covered by unit tests e.g. load_model as this mainly involves the importing of TensorFlow, which is slow, and therefore not done in any of the unit tests.

maxwhitemet

Thanks @gavinevans. I'm happy with the changes made. Approved 👍

gavinevans added 10 commits December 18, 2025 16:27

Addition of Google Film-based temporal interpolation. Addition of a s…

906090c

…pecific plugin and addition of a Google Film option to the temporal interpolation plugin and CLI.

Refactor ForecastPeriodGapFiller class.

8c43de8

Edits.

17fc967

Add acceptance/test_forecast_period_gap_filler.py.

6a7b352

Further edits to temporal interpolation.

0c009eb

Minor edits.

b1da7dd

Minor edits.

d7af663

Add packages to environments.

706ad8c

Update checksums.

e0fa0b5

gavinevans force-pushed the mobt_763_google_film branch from 1949898 to e0fa0b5 Compare December 18, 2025 16:28

gavinevans mentioned this pull request Dec 18, 2025

Support use of Google Film for temporal interpolation metoppv/improver_test_data#118

Merged

bayliffe requested changes Jan 5, 2026

View reviewed changes

gavinevans added 9 commits January 8, 2026 14:43

Edits following review.

06ac06e

Edits to make unit tests pass.

89b5ac0

Checksum updates.

3c6ff9c

Modifications including adding a max_batch option for controlling the…

92707b4

… batched approach used for Google Film interpolation.

Edits to tidy-up and provide a parallelisation option using the loky …

8989472

…parallel backend available using the joblib package.

Corrections to fix unit tests.

1c26891

Extend unit test.

b75f192

Correct indentation error.

5cc6f16

bayliffe requested changes Jan 19, 2026

View reviewed changes

Edits following review comments.

48d84da

bayliffe previously approved these changes Jan 21, 2026

View reviewed changes

maxwhitemet requested changes Jan 27, 2026

View reviewed changes

Address review comments and enhance test coverage.

c0fc3bf

gavinevans dismissed bayliffe’s stale review via c0fc3bf January 28, 2026 17:52

maxwhitemet approved these changes Jan 29, 2026

View reviewed changes

Merge branch 'master' into mobt_763_google_film

65e2108

gavinevans merged commit 970a511 into metoppv:master Jan 29, 2026
6 of 7 checks passed

gavinevans deleted the mobt_763_google_film branch January 29, 2026 11:06

Support use of Google Film for temporal interpolation #2270

Support use of Google Film for temporal interpolation #2270

Uh oh!

Conversation

gavinevans commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bayliffe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bayliffe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bayliffe left a comment

Choose a reason for hiding this comment

Uh oh!

maxwhitemet left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gavinevans commented Jan 28, 2026

Uh oh!

maxwhitemet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gavinevans commented Dec 18, 2025 •

edited

Loading

maxwhitemet left a comment •

edited

Loading