953 stochastic noise #2275
Open
953 stochastic noise #2275
+658
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@maxwhitemet, could you merge/rebase master into your branch. The failing "CI Tests / Test-Coverage (pull_request)" should hopefully be addressed by the now merged #2273 
There does appear to be a new issue potentially with the improver documentation building now though... (different issue) |
maxwhitemet
force-pushed
the
953_stochastic_noise
branch
from
84d3c1b to
897e0cb
Compare
Contributor
|
Ignore the test coverage failure. Fixed in #2282 |
gavinevans
requested changes
Jan 16, 2026
Contributor
gavinevans
left a comment
gavinevans
left a comment
There was a problem hiding this comment.
Thanks @maxwhitemet 👍
I've added some comments below.
improver_tests/precipitation/stochastic_noise/test_StochasticNoise.py
Outdated
Show resolved
Hide resolved
improver_tests/precipitation/stochastic_noise/test_StochasticNoise.py
Outdated
Show resolved
Hide resolved
maxwhitemet
commented
Jan 21, 2026
Contributor
Author
maxwhitemet
left a comment
maxwhitemet
left a comment
There was a problem hiding this comment.
Thank you for the review @gavinevans. I have now made the requested changes.
improver_tests/precipitation/stochastic_noise/test_StochasticNoise.py
Outdated
Show resolved
Hide resolved
improver_tests/precipitation/stochastic_noise/test_StochasticNoise.py
Outdated
Show resolved
Hide resolved
gavinevans
requested changes
Jan 27, 2026
Contributor
gavinevans
left a comment
gavinevans
left a comment
There was a problem hiding this comment.
I've added some minor comments.
maxwhitemet
commented
Jan 28, 2026
Contributor
Author
maxwhitemet
left a comment
maxwhitemet
left a comment
There was a problem hiding this comment.
Thanks @gavinevans. I have implemented your feedback
gavinevans
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #953.
This PR adds the plugin, CLI, and tests for stochastic noise generation.
The acceptance tests show the impact, with data available here.
Testing: