Code coverage check: number of missing lines check only #2292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoseleyS
approved these changes
Jan 29, 2026
Member
MoseleyS
left a comment
MoseleyS
left a comment
There was a problem hiding this comment.
A simple change. I suggest we get feedback from the team as to what we should test, in case there are better ideas.
Contributor
Author
|
Opted for communicating how this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the scenario of a false positive reduction in percentage cover as a result of a reduction in number of lines but the number of uncovered lines has not changed. This change is to check only the number of missing lines (absolute quantity), rather than the percentage (relative quantity).