-
Notifications
You must be signed in to change notification settings - Fork 100
SAMOS: Add constant extrapolation option #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brhooper
wants to merge
10
commits into
metoppv:master
Choose a base branch
from
brhooper:mobt1051_gam_extrapolation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unit tests for new functionality.
…s function. Add associated unit tests.
…lass. Add accompanying unit tests.
…AMOS class. Add accompanying unit tests. Also improve ApplySAMOS doc-string and fix handling of additional predictors in ApplySAMOS unit tests.
937a454 to
3e6e226
Compare
bayliffe
approved these changes
Jan 30, 2026
Contributor
bayliffe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything passes and I cannot see any issues with this. Good work.
gavinevans
approved these changes
Jan 30, 2026
Contributor
gavinevans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brhooper 👍
I think these changes are fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/1051
This PR adds the capability to use constant extrapolation to the
GAMPredictclass and the relevant SAMOS classes and CLIs.When extrapolating along a single term in a GAM, the default behaviour is to extend the trend of that term when predicting for input values which are outside the bounds of the training data. When using constant extrapolation, this will instead treat any values outside of the training range as equal to the smallest/largest value in the training range, as required.
For example, suppose our fitted GAM term were a simple linear term
y = x + 2trained onxvalues in the range [0, 10]. Predictions from this term would look as below, using the two different extrapolation approaches:Testing: