feat: metricq_syslog_option #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmaxde
force-pushed
the
feat_syslog
branch
5 times, most recently
from
ccc4a3b to
5ce43fe
Compare
bmario
requested changes
Nov 5, 2024
devmaxde
force-pushed
the
feat_syslog
branch
3 times, most recently
from
8168afe to
7eb526a
Compare
devmaxde
force-pushed
the
feat_syslog
branch
3 times, most recently
from
a214a5e to
7d769bb
Compare
devmaxde
force-pushed
the
feat_syslog
branch
7 times, most recently
from
ec772e1 to
fa80633
Compare
bmario
requested changes
Dec 11, 2024
metricq/cli/decorator.py
Outdated
| if value == "": | ||
| value = None | ||
|
|
||
| program_name = ctx.params.get("token", "metricq.program") |
Member
There was a problem hiding this comment.
The default should be the process name instead. Or argv[0].
metricq/cli/decorator.py
Outdated
| If used without parameter (for example: ``metricq-check --syslog`` ) the Syslog will default to localhost:514. | ||
| You can also specify a Unix socket (for example: /dev/log) or a custom host (for example: example.com:5114) | ||
| by adding the value to the syslog flag (for example: ``metricq-check --syslog example.com:5114``) |
Member
There was a problem hiding this comment.
Suggested change
| by adding the value to the syslog flag (for example: ``metricq-check --syslog example.com:5114``) | |
| by adding the value to the syslog flag (for example: ``metricq-check --syslog example.com:514``) |
metricq/cli/decorator.py
Outdated
| If used without parameter (for example: ``metricq-check --syslog`` ) the Syslog will default to localhost:514. | ||
| You can also specify a Unix socket (for example: /dev/log) or a custom host (for example: example.com:5114) |
Member
There was a problem hiding this comment.
Suggested change
| You can also specify a Unix socket (for example: /dev/log) or a custom host (for example: example.com:5114) | |
| You can also specify a Unix socket (for example: /dev/log) or a custom host (for example: example.com:514) |
devmaxde
force-pushed
the
feat_syslog
branch
from
fa80633 to
1098da0
Compare
bmario
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the @metricq_syslog() wrapper for click commands, that configures the logger to sent to a Syslog Location (local or remote)