Skip to content

Configure editorconfig#31

Merged
jbampton merged 5 commits intometropolis-retro:mainfrom
jbampton:configure-editorconfig
Apr 10, 2026
Merged

Configure editorconfig#31
jbampton merged 5 commits intometropolis-retro:mainfrom
jbampton:configure-editorconfig

Conversation

@jbampton
Copy link
Copy Markdown
Member

@jbampton jbampton commented Apr 1, 2026

No description provided.

@jbampton jbampton requested a review from BaseMax as a code owner April 1, 2026 13:27
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

@jbampton is attempting to deploy a commit to the retro Team on Vercel.

A member of the Team first needs to authorize it.

@jbampton jbampton self-assigned this Apr 1, 2026
@github-project-automation github-project-automation bot moved this to Backlog in METROPOLIS Apr 1, 2026
@jbampton jbampton moved this from Backlog to In review in METROPOLIS Apr 1, 2026
@jbampton jbampton added this to the Retro milestone Apr 1, 2026
@jbampton jbampton added the good first issue Good for newcomers label Apr 1, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .editorconfig file to include CSS, TypeScript, and TSX files in the indentation rules. The feedback suggests using a double asterisk glob pattern to ensure these settings are applied to files within subdirectories, as the current single asterisk pattern only matches files in the root directory.

Comment thread .editorconfig
BaseMax
BaseMax approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@BaseMax BaseMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go, so css and tsx, etc has been added.

@deepsource-io
Copy link
Copy Markdown

deepsource-io bot commented Apr 10, 2026 •
edited
Loading

DeepSource Code Review

We reviewed changes in fd39765...9f008eb on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Apr 10, 2026 4:52a.m. Review ↗
Secrets Apr 10, 2026 4:52a.m. Review ↗
Python Apr 10, 2026 4:52a.m. Review ↗

@jbampton jbampton merged commit 1ec5333 into metropolis-retro:main Apr 10, 2026
10 of 12 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in METROPOLIS Apr 10, 2026
@jbampton jbampton deleted the configure-editorconfig branch April 10, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BaseMax BaseMax BaseMax approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jbampton jbampton

Labels

good first issue Good for newcomers

Projects

METROPOLIS
Status: Done

Milestone

Retro

Development

Successfully merging this pull request may close these issues.

2 participants

@jbampton @BaseMax