Fix handling of null-terminated callsigns#8
Open
franga2000 wants to merge 1 commit intomfncooper:mainfrom
Open
Fix handling of null-terminated callsigns#8franga2000 wants to merge 1 commit intomfncooper:mainfrom
franga2000 wants to merge 1 commit intomfncooper:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the docs (see also the linked footnote),
CallFromandCallToare null-terminated strings which may contain garbage after the null byte.When testing with Packet Engine Pro (basically just fancy AGWPE), I got random text following the callsigns (e.g.
CALL\x00ABCDE). Splitting on null instead of just stripping it is the correct fix.My guess is that whatever generator of AGWPE data you were testing with always starts with a nulled buffer, but this isn't the case for PE Pro or indeed guaranteed in the spec, which is why this worked for you.