feat(voice-call): handle hangup for rejected inbound calls#16
feat(voice-call): handle hangup for rejected inbound calls#16mgabrielramos wants to merge 1 commit intomainfrom
Conversation
Implemented call hangup logic for rejected inbound calls in `CallManager`. Previously, rejected inbound calls were simply ignored by the `processEvent` method. The code now explicitly creates a call record and hangs it up immediately. - Verified logic manually as tests cannot be run due to missing dependencies. - Handles potential errors from `endCall`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What:
Implemented call hangup logic for rejected inbound calls in
CallManager.💡 Why:
Previously, rejected inbound calls (based on
inboundPolicyorallowFromlist) were simply ignored by theprocessEventmethod. This likely left the call ringing or in an undefined state on the provider side. The code now explicitly creates a call record and hangs it up immediately.✅ Verification:
shouldAcceptInboundreturns false.createInboundCall(trackingcallId,providerCallId, etc.).endCall(call.callId)which:provider.hangupCall.hangup-botand persists it.activeCalls.endCallby logging them.reproduce_issue.test.ts) but was unable to execute due to missing dependencies in the environment (node_modulesnot populated).endCallflow which is known to work for active calls.✨ Result:
Rejected inbound calls are now properly terminated on the provider side and logged in the system.
PR created automatically by Jules for task 17214610368930025336 started by @mgabrielramos