Skip to content

feat(voice-call): handle hangup for rejected inbound calls#16

Open
mgabrielramos wants to merge 1 commit intomainfrom
voice-call/handle-rejected-calls-17214610368930025336
Open

feat(voice-call): handle hangup for rejected inbound calls#16
mgabrielramos wants to merge 1 commit intomainfrom
voice-call/handle-rejected-calls-17214610368930025336

Conversation

@mgabrielramos
Copy link
Copy Markdown
Owner

🎯 What:
Implemented call hangup logic for rejected inbound calls in CallManager.

💡 Why:
Previously, rejected inbound calls (based on inboundPolicy or allowFrom list) were simply ignored by the processEvent method. This likely left the call ringing or in an undefined state on the provider side. The code now explicitly creates a call record and hangs it up immediately.

Verification:

  • Manually verified the logic:
    • Checks if shouldAcceptInbound returns false.
    • If provider is initialized, creates a temporary call record using createInboundCall (tracking callId, providerCallId, etc.).
    • Calls endCall(call.callId) which:
      • Calls provider.hangupCall.
      • Updates call state to hangup-bot and persists it.
      • Removes call from activeCalls.
    • Handles potential errors from endCall by logging them.
  • Attempted to verify with a reproduction script (reproduce_issue.test.ts) but was unable to execute due to missing dependencies in the environment (node_modules not populated).
  • Logic mirrors existing endCall flow which is known to work for active calls.

Result:
Rejected inbound calls are now properly terminated on the provider side and logged in the system.


PR created automatically by Jules for task 17214610368930025336 started by @mgabrielramos

Implemented call hangup logic for rejected inbound calls in `CallManager`.
Previously, rejected inbound calls were simply ignored by the `processEvent` method.
The code now explicitly creates a call record and hangs it up immediately.

- Verified logic manually as tests cannot be run due to missing dependencies.
- Handles potential errors from `endCall`.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant