🧹 Refactor browser interactions to reduce duplication#20
🧹 Refactor browser interactions to reduce duplication#20mgabrielramos wants to merge 1 commit intomainfrom
Conversation
…helper - Introduce `runPlaywrightAction` to encapsulate common logic. - Reduce code duplication and improve maintainability.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR refactors
hoverViaPlaywrightandclickViaPlaywrightinsrc/browser/pw-tools-core.interactions.tsto use a shared helper functionrunPlaywrightAction. This reduces code duplication by centralizing the logic for page retrieval, state restoration, element resolution, timeout handling, and error wrapping.Changes:
runPlaywrightActionhelper.hoverViaPlaywrightto use the helper.clickViaPlaywrightto use the helper.Verification:
bun testsetup mockingpw-sessionand PlaywrightLocator.hoverandclickactions are correctly delegated and options are respected.PR created automatically by Jules for task 15131374045669648585 started by @mgabrielramos