Skip to content

🧹 Refactor browser interactions to reduce duplication#20

Open
mgabrielramos wants to merge 1 commit intomainfrom
refactor-pw-interactions-15131374045669648585
Open

🧹 Refactor browser interactions to reduce duplication#20
mgabrielramos wants to merge 1 commit intomainfrom
refactor-pw-interactions-15131374045669648585

Conversation

@mgabrielramos
Copy link
Copy Markdown
Owner

This PR refactors hoverViaPlaywright and clickViaPlaywright in src/browser/pw-tools-core.interactions.ts to use a shared helper function runPlaywrightAction. This reduces code duplication by centralizing the logic for page retrieval, state restoration, element resolution, timeout handling, and error wrapping.

Changes:

  • Added runPlaywrightAction helper.
  • Updated hoverViaPlaywright to use the helper.
  • Updated clickViaPlaywright to use the helper.

Verification:

  • Verified using a temporary bun test setup mocking pw-session and Playwright Locator.
  • Confirmed that hover and click actions are correctly delegated and options are respected.

PR created automatically by Jules for task 15131374045669648585 started by @mgabrielramos

…helper

- Introduce `runPlaywrightAction` to encapsulate common logic.
- Reduce code duplication and improve maintainability.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant