Skip to content

⚡ Optimize memory sync N+1 queries #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgabrielramos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize memory sync N+1 queries #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 44 additions & 17 deletions src/memory/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,9 +1131,19 @@ export class MemoryIndexManager {

const tasks = fileEntries.map((entry) => async () => {
const record = this.db
.prepare(`SELECT hash FROM files WHERE path = ? AND source = ?`)
.get(entry.path, "memory") as { hash: string } | undefined;
if (!params.needsFullReindex && record?.hash === entry.hash) {
const fileHashes = new Map<string, string>();
if (!params.needsFullReindex) {
const rows = this.db
.prepare(`SELECT path, hash FROM files WHERE source = ?`)
.all("memory") as Array<{ path: string; hash: string }>;
for (const row of rows) {
fileHashes.set(row.path, row.hash);
}
}

const tasks = fileEntries.map((entry) => async () => {
const existingHash = fileHashes.get(entry.path);
if (!params.needsFullReindex && existingHash === entry.hash) {
if (params.progress) {
params.progress.completed += 1;
params.progress.report({
Expand Down Expand Up @@ -1184,16 +1194,6 @@ export class MemoryIndexManager {
needsFullReindex: boolean;
progress?: MemorySyncProgressState;
}) {
const files = await this.listSessionFiles();
const activePaths = new Set(files.map((file) => this.sessionPathForFile(file)));
const indexAll = params.needsFullReindex || this.sessionsDirtyFiles.size === 0;
log.debug("memory sync: indexing session files", {
files: files.length,
indexAll,
dirtyFiles: this.sessionsDirtyFiles.size,
batch: this.batch.enabled,
concurrency: this.getIndexConcurrency(),
});
if (params.progress) {
params.progress.total += files.length;
params.progress.report({
Expand All @@ -1203,6 +1203,16 @@ export class MemoryIndexManager {
});
}

const fileHashes = new Map<string, string>();
if (!params.needsFullReindex) {
const rows = this.db
.prepare(`SELECT path, hash FROM files WHERE source = ?`)
.all("sessions") as Array<{ path: string; hash: string }>;
for (const row of rows) {
fileHashes.set(row.path, row.hash);
}
}

const tasks = files.map((absPath) => async () => {
if (!indexAll && !this.sessionsDirtyFiles.has(absPath)) {
if (params.progress) {
Expand All @@ -1225,10 +1235,8 @@ export class MemoryIndexManager {
}
return;
}
const record = this.db
.prepare(`SELECT hash FROM files WHERE path = ? AND source = ?`)
.get(entry.path, "sessions") as { hash: string } | undefined;
if (!params.needsFullReindex && record?.hash === entry.hash) {
const existingHash = fileHashes.get(entry.path);
if (!params.needsFullReindex && existingHash === entry.hash) {
if (params.progress) {
params.progress.completed += 1;
params.progress.report({
Expand All @@ -1248,6 +1256,25 @@ export class MemoryIndexManager {
total: params.progress.total,
});
}
});
params.progress.completed += 1;
params.progress.report({
completed: params.progress.completed,
total: params.progress.total,
});
}
this.resetSessionDelta(absPath, entry.size);
return;
}
await this.indexFile(entry, { source: "sessions", content: entry.content });
this.resetSessionDelta(absPath, entry.size);
if (params.progress) {
params.progress.completed += 1;
params.progress.report({
completed: params.progress.completed,
total: params.progress.total,
});
}
});
await this.runWithConcurrency(tasks, this.getIndexConcurrency());

Expand Down