🧹 [code health improvement] Handle call hangup in Voice Call Events#8
🧹 [code health improvement] Handle call hangup in Voice Call Events#8mgabrielramos wants to merge 1 commit intomainfrom
Conversation
Add implementation for hanging up rejected inbound calls in `extensions/voice-call/src/manager/events.ts`. Add unit test `extensions/voice-call/src/manager/events.test.ts` to verify the logic. Remove TODO comment.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The code health issue addressed
Implemented the logic to hang up rejected inbound calls in
extensions/voice-call/src/manager/events.ts, replacing a TODO.💡 Why: How this improves maintainability
Ensures that calls blocked by inbound policy are actively terminated rather than silently ignored, preventing stuck calls or confused users.
✅ Verification: How you confirmed the change is safe
Added a new unit test
extensions/voice-call/src/manager/events.test.tswhich mocks theCallManagerContextandVoiceCallProvider, verifying thathangupCallis invoked with the correct parameters when a call is rejected.Ran the new test successfully.
✨ Result: The improvement achieved
The codebase now handles call rejection properly according to the TODO, improving robustness.
PR created automatically by Jules for task 11129053774006451996 started by @mgabrielramos