Skip to content

Conversation

@JaschaW
Copy link
Member

@JaschaW JaschaW commented Nov 19, 2025

Description of Changes

Introduced a new function, findComponentChildren4, to replace the previous child-collection logic.
The older implementation was matching nodes from unrelated components due to partial string matching, which caused naming collisions and incorrect traversal results.

The new version uses stricter token-based matching and reliably limits the search to nodes that belong to the intended component only.

This prevents accidental inclusion of similarly named nodes such as:

  • root_C0_root (actual component)
  • ik_hand_root_C0_root (different component but previously matched)

Testing Done

Verified the function on isolated components.

  • Tested on complex guides exhibiting the previous failure cases, including components with overlapping name tokens.
  • Confirmed that nodes such as root_C0_root no longer incorrectly match nodes from components like ik_hand_root_C0_root.
  • Validated that the change eliminates the runaway auto-renaming loop that previously generated dozens of unnecessary index variations.

All tests confirm correct component isolation and stable traversal without unintended matches.

@miquelcampos miquelcampos self-assigned this Nov 25, 2025
@miquelcampos miquelcampos added the enhancement New feature or request label Nov 25, 2025
@github-project-automation github-project-automation bot moved this to To Do in mGear DEV Nov 25, 2025
@miquelcampos miquelcampos moved this from To Do to WIP in mGear DEV Nov 25, 2025
@miquelcampos miquelcampos merged commit fcd1487 into master Dec 8, 2025
0 of 3 checks passed
@github-project-automation github-project-automation bot moved this from WIP to 5.2.0 in mGear DEV Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: 5.2.0

Development

Successfully merging this pull request may close these issues.

3 participants