Fix html injection in formatToHtml
#28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulidtko
commented
Mar 11, 2025
| </code> | ||
| <code><pre> | ||
| {escape(headers)} | ||
| </pre></code> |
Author
There was a problem hiding this comment.
The added wrapping into <pre> allows to simply ditch the \n → <br/>\n shenanigans — within <pre>, the contained (html-escaped) html blob will render as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cześć @mgeeky ! Thanks for this script, super useful. 🙏
A simple drive-by fix here, in html export:
<html>...</html>blob — interpolating it right into the output report html is not good enough; it should go throughhtml.escape()first.Otherwise, contents of email sample bleed out of the
Original SMTP Headersspoiler, wrecking the report:And on the same sample, fixed:
Hoping for easy merge, HTH