Fix heistMerge execution and more...#16
Open
lhugolach wants to merge 6 commits intomhibbins:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix heistMerge execution
Hello,
at the moment, if the
heistMergecommand is used, execution stops with the following error:The error is triggered in elseif where it retrieves the float value contained in the key
#9but if you notice in the dictionary
datethis key is not presentSolution I propose...
My correction adds this key by setting it to 0.0 as a float value
Please let me know if I am proposing something wrong
More: Fix deprecated python file opening mode
In the
readSeqsfunction inseqtools.pywhen reading sequences, the read mode "rU" is used which is now officially deprecated in the python documentation since version 3.4.I removed this mode after some analyses were blocked by python with the error:
I specified the "r" (open for reading) mode because simple text files are read
More: Improved deletion of tmp files
I wanted to improve the management of the deletion of tmp files.
In short, I kept the deletion system at the end of the analysis, but transferred the triggering logic to the main, so as to give the output path as a parameter.
This allows tmp files to be deleted at any path specified in the
--outputdirargument of HeIST.More: Check if output folder exists function
I revised the logic of output file management.
If a destination path with a sub-folder (e.g.
./folder/file) is specified in the--outputdirparameter, and this folder does not exist, a function will take care of creating it itself.Specifically, the code will remove the last element from the path, assuming it is a file.
So if only the file name is specified, in anticipation of having the output files in the execution root, they will be generated in the same way as before.
If a series of non-existent sub-folders is specified, the entire path will be created. (e.g.
./folder1/folder2/folder3/file)Last tip
I have changed all version references of HeIST to 0.4.1, defining this change as a hotfix.
I therefore suggest creating a new tag.
Finally, I ask you to update the image on PyPI.org as I currently see that the latest version available is 0.3.1 so that anyone can use the stable version of HeIST (See #15)
Thank you
Ps: about the commit comment
Fix KeyError: #9 in heistMerge executionGitHub understood#9as a tag to a previous pull request.Was completely unintentional, I hope I didn't cause any confusion.