Fix repeatably and un-catchable errors for encrypted or unsupported version zip files.#46
Open
mickeyjohn wants to merge 1 commit intomhr3:masterfrom
Open
Fix repeatably and un-catchable errors for encrypted or unsupported version zip files.#46mickeyjohn wants to merge 1 commit intomhr3:masterfrom
mickeyjohn wants to merge 1 commit intomhr3:masterfrom
Conversation
Fix un-catch-able errors for encrypted or unsupported version zip files
mickeyjohn
changed the title
gazal-k
approved these changes
Feb 13, 2023
|
Looks like this repository may not be maintained anymore and someone may need to fork it. Or @mhr3 would you please add other maintainers to this repo? |
Owner
Sure, sorry, didn't have time to maintain this lib |
No worries. I can help maintaining this repo. We could add some quality gates (CI) and start accepting contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the error is applied for the whole zip file, the fix is to throw the error even only once and stop parsing the zip file.