Angular native wrappers - #3933#4206
Open
GCHQDev01001010 wants to merge 16 commits intomi6:developfrom
Open
Conversation
23 tasks
Contributor
GCHQ-Developer-112
left a comment
GCHQ-Developer-112
left a comment
There was a problem hiding this comment.
This is just an initial review, I will review this again most likely some time next week
Comment on lines
+10
to
+11
| cd ../angular-community-supported | ||
| npm i --package-lock-only |
Contributor
There was a problem hiding this comment.
I'm worried that this will affect our usual releases
| dist/ | ||
| www/ | ||
| loader/ | ||
| components/ |
Contributor
There was a problem hiding this comment.
This will mean changes to our components will not be committed - please remove this line
| "dist/", | ||
| "loader/", | ||
| "hydrate/", | ||
| "components/", |
Contributor
There was a problem hiding this comment.
Why has this been added?
Comment on lines
+132
to
+134
| ### React & Angular | ||
|
|
||
| Stencil provides [plugins](https://stenciljs.com/docs/overview), which outputs wrapped framework agnostic components. During the build stage, React components are dynamically generated and are accessible from the React package. | ||
| Stencil provides [plugins](https://stenciljs.com/docs/overview), which outputs wrapped framework agnostic components. During the build stage, Native components for React and Angular are dynamically generated and are accessible from their respective packages. |
Contributor
There was a problem hiding this comment.
Please move the information about Angular into a separate heading and explain that this is a community supported package and what that means for the contributions
GCHQ-Developer-299
requested changes
Jan 26, 2026
Contributor
GCHQ-Developer-299
left a comment
GCHQ-Developer-299
left a comment
There was a problem hiding this comment.
Will review again when @GCHQ-Developer-112 's comments have been addressed
GCHQDev01001010
force-pushed
the
3933-angular-native-output
branch
from
bdd2680 to
227365d
Compare
Adds references to the upcoming Angular packages to the build, commit and ci files. Also tweaks the contributing documentation slightly. re mi6#3933
…ive components Adds the angularOutputTarget plugin for stencil and includes relevant config so that the natively wrapped ICDS elements are output as a package. Also adds a pure output for the web components as an intermediary packaged within @ukic/web-components for the Angular plugin to make use of. ref mi6#3933
…ing the angular native wrappers Provides the underlying folders structure, npm config, scripts and such for publishing the Angular package. Also includes the 3.18.0 output from the stencil generator. closes mi6#3933
… of angular in peer deps
…e angular packages for audit
…wrappers to use ICDS v 3.19e
GCHQDev01001010
force-pushed
the
3933-angular-native-output
branch
from
227365d to
cdf95c7
Compare
…sure builds output correctly updates the various exports and entry points to account for changes in how the latest version of the stencil output targets bundle the module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Set up new output targets in the stencil config to output native angular wrapper components in a similar vein to the react components. Versions have been included that will allow the integrating developers to import the components as standalone items one-by-one at need or as a whole module. This also required the addition/alteration of the custom-elements-dist output to create an internal package for the web-components that the angular output plugin could use.
The package is included in the pack all script and other checks. Also includes an Angular schematic in the package so users can install simply with "ng add".
Documentation has been updated to indicate installation and useage of the new package and components and to provide clarity that this is a community-developed and supported addition as per the ICDS team's request.
(This is a rebuild of #4180 )
Related issue
closes #3933
& ic-design-system 850
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes