Conversation
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3857-upgrade-stencil/web-components |
|
View your canary branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3857-upgrade-stencil/canary-web-components |
|
Cypress visual tests failed. |
GCHQ-Developer-299
left a comment
GCHQ-Developer-299
left a comment
There was a problem hiding this comment.
I think the failure in static analysis tests will prevent you updating the cypress images too, but fingers crossed after that they'll pass :)
There was a problem hiding this comment.
Looks like the Static Analysis tests pipeline is failing on this file
GCHQ-Developer-112
left a comment
GCHQ-Developer-112
left a comment
There was a problem hiding this comment.
There are some unexpected line removals in a number of the component READMEs
Not sure if this is out of scope but it would be good to have a review of the audit-ci to see if any exceptions can be removed
| - [ic-checkbox-group](../ic-checkbox-group) | ||
| - [ic-radio-group](../ic-radio-group) |
There was a problem hiding this comment.
This looks like a regression. I wouldn't expect this line to be removed
| - [ic-breadcrumb](../ic-breadcrumb) | ||
| - [ic-footer-link](../ic-footer-link) |
There was a problem hiding this comment.
Looks like an unintended change
| - [ic-step](../ic-step) | ||
| - [ic-toast](../ic-toast) |
There was a problem hiding this comment.
Looks like an unintended change
ec1467
force-pushed
the
3857-upgrade-stencil
branch
8 times, most recently
from
759a876 to
33173d5
Compare
ec1467
force-pushed
the
3857-upgrade-stencil
branch
4 times, most recently
from
0f845ee to
880fc7e
Compare
Upgrade @stencil/core to v4.41.1; update unit test snapshots; fix ic-button theme logic.
Upgrade @stencil/core to v4.41.1, fix tests, update snaphots. No functional changes.
ec1467
force-pushed
the
3857-upgrade-stencil
branch
from
880fc7e to
68fbb77
Compare
3 participants
Summary of the changes
Related issue
#4193
Checklist
General