feat(web-components): add slot for an icon in ic-tooltip#4260
Draft
GCHQDeveloper416 wants to merge 5 commits intodevelopfrom
Draft
feat(web-components): add slot for an icon in ic-tooltip#4260GCHQDeveloper416 wants to merge 5 commits intodevelopfrom
GCHQDeveloper416 wants to merge 5 commits intodevelopfrom
Conversation
Contributor
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/734-tooltip-icon/web-components |
6bb1730 to
c7b79ec
Compare
Contributor
|
Cypress visual tests failed. |
55c7a47 to
72d64a4
Compare
72d64a4 to
d906a10
Compare
Add slot for icon within tooltip. Add prop for alt-text for icon. Storybook updated.
…nd without alt-text added Updating tests. Test for icon on tooltip with and without alt-text added
Updated tooltip stories in react storybook
445a325 to
06b43f8
Compare
06b43f8 to
9afc38c
Compare
update cypress visual regression tests
40a8f97 to
73822d3
Compare
updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Add slot for icon within tooltip. Tooltip icon stays on left and aligned with first line of text. Alt-text prop enables text to be added for the icons for screenreaders if alt text is given.
Related issue
#734
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes