Draft
Conversation
Contributor
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/4238-lang-attribute-input-label/web-components |
jd3267
force-pushed
the
4238-lang-attribute-input-label
branch
from
a501385 to
3518e86
Compare
Contributor
|
Could use a storybook example of using the new slot. |
Contributor
And a Cypress visual regression test too please |
jd3267
force-pushed
the
4238-lang-attribute-input-label
branch
2 times, most recently
from
59210cd to
5239443
Compare
update to docs for adding of label slot to ic-input-label
…t-label update to docs for adding of label slot to ic-input-label
addition of label slot to allow adding lang attributes to text
jd3267
force-pushed
the
4238-lang-attribute-input-label
branch
from
5239443 to
14332d8
Compare
adds story example to checkbox-group to test slotted label with changes to input-label
add french words to cspell for language test
jd3267
force-pushed
the
4238-lang-attribute-input-label
branch
from
14332d8 to
67c5e9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Added label slot to ic-input-label to allow for addition of lang attributes to text
Related issue
#4238
Checklist
General