Skip to content

Conversation

@robsonj
Copy link

@robsonj robsonj commented May 21, 2013

Upgraded Newtonsoft.Json to v5.0.5

Upgraded Newtonsoft.Json to v5.0.5
@micahlmartin
Copy link
Owner

What does this buy us? Any major upgrades or performance increase?

@robsonj
Copy link
Author

robsonj commented May 21, 2013

We needed to upgrade in order to use the gelf libs in conjunction with other 3rd party dll's which are reliant on JSON v5.0.5.

Jonathan Robson
http://about.me/jonathanrobson

On May 21, 2013, at 11:24 AM, Micah Martin notifications@github.com wrote:

What does this buy us? Any major upgrades or performance increase?


Reply to this email directly or view it on GitHub.

@micahlmartin
Copy link
Owner

The build script should internalize the dependencies and not be affected by another version of the libraries in the bin folder. Check out line 113 https://github.com/micahlmartin/gelf4net/blob/master/default.ps1.

@robsonj
Copy link
Author

robsonj commented May 22, 2013

Yea, you are right on the JSON stuff, it looks like you have a dependency on log4net 1.2.11 with the new public key though, which conflicts with the v1.2.11 we are using which has the old public key, so we still can use the nuget package directly unfortunately

On May 21, 2013, at 3:34 PM, Micah Martin notifications@github.com wrote:

The build script should internalize the dependencies and not be affected by another version of the libraries in the bin folder. Check out line 113 https://github.com/micahlmartin/gelf4net/blob/master/default.ps1.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants